-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors for gcc 14 #8553
Fix errors for gcc 14 #8553
Conversation
CT Test Results 3 files 143 suites 49m 46s ⏱️ For more details on these failures, see this check. Results for commit f5ac901. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It looks good aside from a small issue that broke float_SUITE
. :-)
With GCC 14 series, the following error exists: fp_drv.c: In function 'control': fp_drv.c:126:48: error: passing argument 2 of 'erl_drv_thread_join' from incompatible pointer type [-Wincompatible-pointer-types] 126 | else if (0 != erl_drv_thread_join(tid, &res_str)) | ^~~~~~~~ | | | char ** In file included from fp_drv.c:43: /build/tmp/work/core2-64-poky-linux/erlang/27.0/git/erts/emulator/beam/erl_driver.h:487:50: note: expected 'void **' but argument is of type 'char **' 487 | EXTERN int erl_drv_thread_join(ErlDrvTid, void **respp); | ~~~~~~~^~~~~
With GCC 14 series, the following error exists: dead_port.c:43:26: error: return type defaults to 'int' [-Wimplicit-int] 43 | #define MAIN(argc, argv) main(argc, argv) | ^~~~ dead_port.c:50:1: note: in expansion of macro 'MAIN' 50 | MAIN(argc, argv) | ^~~~
With GCC 14 series the following error exists: unlink_signal_drv.c: In function 'start': unlink_signal_drv.c:77:17: error: assignment to 'ErlDrvData' {aka 'struct _erl_drv_data *'} from incompatible pointer type 'ErlDrvPort' {aka 'struct _erl_drv_port *'} [-Wincompatible-pointer-types] 77 | state->port = port; | ^ unlink_signal_drv.c: In function 'output': unlink_signal_drv.c:86:27: error: passing argument 1 of 'driver_set_timer' from incompatible pointer type [-Wincompatible-pointer-types] 86 | driver_set_timer(state->port, 2); | ~~~~~^~~~~~ | | | ErlDrvData {aka struct _erl_drv_data *}
df79492
to
f5ac901
Compare
Merged, thanks for the PR! |
Hi,
When building Erlang/OTP 27 with GCC 14.1.0, I got some compilations errors.
Thanks.